Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLD-338-rendering-PGW #41

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

CLD-338-rendering-PGW #41

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7586fbb
CLD-338-rendering-PGW
asad-rafter Dec 16, 2024
9ab65cc
update the cloudinary gallery widget script
asad-rafter Jan 7, 2025
9842857
modified the gallery widget script inclusion
asad-rafter Jan 15, 2025
bd70463
fixed the render gallery widget
asad-rafter Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions cartridges/cloudinary_sfra_changes/cartridge/templates/default/product/bundleDetails.isml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@

<iscomment> Custom Start: include cloudinary shrinkwrap. </iscomment>
<isset name="CLDImagePageTypeSettings" value="${JSON.parse(dw.system.Site.current.preferences.custom.CLDImagePageTypeSettings)}" scope="page"/>
<isif condition="${dw.system.Site.current.preferences.custom.CLDGalleryEnabled}">
<script src="${dw.system.Site.current.preferences.custom.CLDGalleryJSURL}" onload="window.cldProductGallery = cloudinary; window.renderCloudinaryGalleryWidget();"> </script>
</isif>
<isif condition="${(CLDImagePageTypeSettings.pdp.enabled && CLDImagePageTypeSettings.pdp.automateResponsivenessWithJS) || (CLDImagePageTypeSettings.cldPdpSwatch.enabled && CLDImagePageTypeSettings.cldPdpSwatch.automateResponsivenessWithJS)}">
<isinclude template="include/cloudinaryShrinkwrap"/>
</isif>
Expand Down Expand Up @@ -53,6 +50,7 @@
<iscomment>Custom start: add cloudinary PGW</iscomment>
<isif condition="${pdict.cloudinary && pdict.cloudinary.isEnabled && (pdict.cloudinary.galleryEnabled || pdict.cloudinary.isGalleryEnabled)}">
<isinclude template="product/components/cloudinaryGallery" />
<script src="${dw.system.Site.current.preferences.custom.CLDGalleryJSURL}" onload="window.cldProductGallery = cloudinary; window.renderCloudinaryGalleryWidget();"> </script>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the legacy calls to renderCloudinaryGalleryWidget from https://github.com/asad-rafter/cloudinary_sfcc_site_cartridge/blob/984285740779e611bacfdcb5f6cc623a559ff505/cartridges/int_cloudinary/cartridge/js/cloudinaryWidgets.js#L93

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuval-cloudinary made the changes

<iselse>
<!-- Product Images Carousel -->
<isinclude template="product/components/imageCarousel" />
Expand Down
4 changes: 1 addition & 3 deletions cartridges/cloudinary_sfra_changes/cartridge/templates/default/product/productDetails.isml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@

<iscomment> Custom Start: include cloudinary shrinkwrap. </iscomment>
<isset name="CLDImagePageTypeSettings" value="${JSON.parse(dw.system.Site.current.preferences.custom.CLDImagePageTypeSettings)}" scope="page"/>
<isif condition="${dw.system.Site.current.preferences.custom.CLDGalleryEnabled}">
<script src="${dw.system.Site.current.preferences.custom.CLDGalleryJSURL}" onload="window.cldProductGallery = cloudinary; window.renderCloudinaryGalleryWidget();"> </script>
</isif>
<isif condition="${(CLDImagePageTypeSettings.pdp.enabled && CLDImagePageTypeSettings.pdp.automateResponsivenessWithJS) || (CLDImagePageTypeSettings.cldPdpSwatch.enabled && CLDImagePageTypeSettings.cldPdpSwatch.automateResponsivenessWithJS)}">
<isinclude template="include/cloudinaryShrinkwrap"/>
</isif>
Expand Down Expand Up @@ -42,6 +39,7 @@
<iscomment>Custom start: add cloudinary PGW</iscomment>
<isif condition="${pdict.cloudinary && pdict.cloudinary.isEnabled && pdict.cloudinary.galleryEnabled}">
<isinclude template="product/components/cloudinaryGallery" />
<script src="${dw.system.Site.current.preferences.custom.CLDGalleryJSURL}" onload="window.cldProductGallery = cloudinary; window.renderCloudinaryGalleryWidget();"> </script>
<isset name="isBundleOrSet" value="${false}" scope="page" />
<iselse>
<!-- Product Images Carousel -->
Expand Down
7 changes: 4 additions & 3 deletions cartridges/cloudinary_sfra_changes/cartridge/templates/default/product/setDetails.isml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@

<iscomment> Custom Start: include cloudinary shrinkwrap. </iscomment>
<isset name="CLDImagePageTypeSettings" value="${JSON.parse(dw.system.Site.current.preferences.custom.CLDImagePageTypeSettings)}" scope="page"/>
<isif condition="${dw.system.Site.current.preferences.custom.CLDGalleryEnabled}">
<script src="${dw.system.Site.current.preferences.custom.CLDGalleryJSURL}" onload="window.cldProductGallery = cloudinary; window.renderCloudinarySetGalleryWidgets();"></script>
</isif>
<isif condition="${(CLDImagePageTypeSettings.pdp.enabled && CLDImagePageTypeSettings.pdp.automateResponsivenessWithJS) || (CLDImagePageTypeSettings.cldPdpSwatch.enabled && CLDImagePageTypeSettings.cldPdpSwatch.automateResponsivenessWithJS)}">
<isinclude template="include/cloudinaryShrinkwrap"/>
</isif>
Expand Down Expand Up @@ -55,6 +52,10 @@
</div>
</div>
<isinclude template="product/components/setItems" />

<isif condition="${dw.system.Site.current.preferences.custom.CLDGalleryEnabled}">
<script src="${dw.system.Site.current.preferences.custom.CLDGalleryJSURL}" onload="window.cldProductGallery = cloudinary; window.renderCloudinarySetGalleryWidgets();"></script>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the legacy calls to renderCloudinarySetGalleryWidget from https://github.com/asad-rafter/cloudinary_sfcc_site_cartridge/blob/984285740779e611bacfdcb5f6cc623a559ff505/cartridges/int_cloudinary/cartridge/js/cloudinaryWidgets.js#L95

</isif>
<hr>
<iscomment>Custom start: Add cloudinary video player</iscomment>
<isif condition="${pdict.cloudinary && pdict.cloudinary.isEnabled && pdict.cloudinary.videoEnabled}">
Expand Down