CLD-340-fixed-video-image-issue #98
Conversation
| </div> | ||
|
|
||
| <isscript> |
There was a problem hiding this comment.
The CSS part should be before the HTML
cartridges/int_cloudinary_pd/cartridge/static/default/js/cloudinaryVideos.js
Outdated
Show resolved
Hide resolved
| @@ -35,7 +38,7 @@ $(document).ready(function () { | |||
| conf.secure_distribution = window.cname; | |||
| conf.private_cdn = true; | |||
| } | |||
| window.cld = window.cloudinary.Cloudinary.new(conf); | |||
| initializeCloudinaryPlayers(); | |||
| window.conf = conf; | |||
There was a problem hiding this comment.
Please move this part and the related code to window.initializeCloudinaryPlayers();
..._cloudinary_pd/cartridge/templates/default/experience/components/assets/cloudinaryVideo.isml
Show resolved
Hide resolved
|
@yuval-cloudinary requested changes have been made |
cartridges/int_cloudinary_pd/cartridge/static/default/js/cloudinaryVideos.js
Outdated
Show resolved
Hide resolved
|
@yuval-cloudinary Just so you know as I mentioned in ticket comments these changes are not working and they are not allowing to render the video. Without these changes, it works fine. |
| if (shrinkWrapJs) { | ||
| shrinkWrapJs.parentNode.removeChild(shrinkWrapJs); | ||
| } | ||
| window.cldPDVideoPlayer = cloudinary; |
There was a problem hiding this comment.
@asad-rafter This should be part of the script onload
| * it waits until streaming videos fully load. We need to delay initializing | ||
| * Cloudinary video player a little bit. | ||
| */ | ||
| initializeCloudinaryPlayers(); |
There was a problem hiding this comment.
@asad-rafter This should be part of the script onload
There was a problem hiding this comment.
@yuval-cloudinary is our custom method, it will not work on script onLoad because when the cloudinary script loads our custom script hasn't loaded yet and it gives an error that initializeCloudinaryPlayers(); it is not a function.
There was a problem hiding this comment.
@asad-rafter Then please move the call to cloudinaryVideos.js so it is loaded before trying to execute initializeCloudinaryPlayers()
There was a problem hiding this comment.
@asad-rafter Our end goal is that each page to have the following structure:
- A single line calling CLDPDShrinkwrapJSURL
- One or more div sections of cloudinary-video-container
- A call to initializeCloudinaryPlayers()
These sections should be introduced one following the other without any delays or async operations
There was a problem hiding this comment.
@yuval-cloudinary we are not using CLDPDShrinkwrapJSURL in video
There was a problem hiding this comment.
@asad-rafter Then please move the call to cloudinaryVideos.js so it is loaded before trying to execute initializeCloudinaryPlayers()
@yuval-cloudinary Its already in cloudinaryVideos.js, I didn't get your point here
|
This PR is not needed as we need to create a new PR with new changes |
No description provided.