Fix obtaining identifier on rails >= 6.1 #493
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Summary of Changes
This PR is fixing the bug from my previous PR. (#489)
I found the issue I fixed in my previous PR is reproduced after I upgraded my project to Rails 6.1.
And I did some research and noticed that there is an API change between Rails 6.0 and 6.1.
Rails 6.0
Rails 6.1
The
attr_name
is no longer converted to String type. That led to fetching the incorrect identifier after storage.So I change the code to use the public method
read_attribute
for avoiding internal API changes.What does this PR address?
Are tests included?
Reviewer, please note:
Checklist: