me-17976: tests if videos are playing on subtitles and captions page #792
Conversation
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| return pomPages.subtitlesAndCaptionsVideosPage.subtitlesAndCaptionsSrtAndVttVideoComponent.clickPlay(); | ||
| }); | ||
| await test.step('Validating that srt and vtt video is playing', async () => { | ||
| await pomPages.subtitlesAndCaptionsVideosPage.subtitlesAndCaptionsSrtAndVttVideoComponent.validateVideoIsPlaying(true); |
There was a problem hiding this comment.
This comment applies to all steps, i do not think you need this prefix as it is already scoped by the parent object subtitlesAndCaptionsVideosPage, it is better to name it like this in my eyes which is shorter yet as describitve as the long one
| await pomPages.subtitlesAndCaptionsVideosPage.subtitlesAndCaptionsSrtAndVttVideoComponent.validateVideoIsPlaying(true); | |
| await pomPages.subtitlesAndCaptionsVideosPage.srtAndVttVideo.validateVideoIsPlaying(true); |
| const SUBTITLES_AND_CAPTIONS_PAGE_SRT_AND_VTT_VIDEO_SELECTOR = '//*[@id="player_html5_api"]'; | ||
| const SUBTITLES_AND_CAPTIONS_PAGE_PLAYLIST_SUBTITLES_VIDEO_SELECTOR = '//*[@id="playlist_html5_api"]'; | ||
| const SUBTITLES_AND_CAPTIONS_PAGE_PACED_STYLES_CAPTIONS_VIDEO_SELECTOR = '//*[@id="paced_html5_api"]'; | ||
| const SUBTITLES_AND_CAPTIONS_PAGE_KARAOKE_VIDEO_SELECTOR = '//*[@id="karaoke_html5_api"]'; | ||
| const SUBTITLES_AND_CAPTIONS_PAGE_TRANSLATED_TRANSCRIPT_VIDEO_SELECTOR = '//*[@id="translated-transcript_html5_api"]'; |
There was a problem hiding this comment.
Same here in my eyes you may want to remove the prefix SUBTITLES_AND_CAPTIONS ... you may want to think also about how this is in the other pages as well.
There was a problem hiding this comment.
I will change it for this page and will open a separate task to refactor all other pages accordingally.
Relevant task - https://cloudinary.atlassian.net/browse/ME-17976
This test is navigating to subtitles and captions page (subtitles-and-captions.html) and make sure that videos element are playing.