remove private distribution limitation for SEO suffix

cloudinary · Jan 1, 2017 · 3ee4f90 · 3ee4f90
1 parent 52e3e8e
commit 3ee4f90
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/Cloudinary.Test/ApiTest.cs b/Cloudinary.Test/ApiTest.cs
@@ -845,12 +845,12 @@ public void TestDisallowUseRootPathIfNotImageUploadForRaw()
             m_api.UrlImgUp.UseRootPath(true).PrivateCdn(true).ResourceType("raw").BuildUrl("test");
         }
 
-        [Test]
-        [ExpectedException(ExpectedException = typeof(NotSupportedException), ExpectedMessage = "URL Suffix only supported in private CDN!")]
-        public void TestDisallowUrlSuffixInSharedDistribution()
-        {
-            m_api.UrlImgUp.Suffix("hello").BuildUrl("test");
-        }
+        //[Test]
+        //[ExpectedException(ExpectedException = typeof(NotSupportedException), ExpectedMessage = "URL Suffix only supported in private CDN!")]
+        //public void TestDisallowUrlSuffixInSharedDistribution()
+        //{
+        //    m_api.UrlImgUp.Suffix("hello").BuildUrl("test");
+        //}
 
         [Test]
         [ExpectedException(ExpectedException = typeof(NotSupportedException), ExpectedMessage = "URL Suffix only supported for image/upload and raw/upload!")]
@@ -920,6 +920,13 @@ public void TestSupportUrlSuffixForRawUploads()
             Assert.AreEqual("http://testcloud-res.cloudinary.com/files/test/hello", actual);
         }
 
+        [Test]
+        public void TestSupportUrlSuffixForSharedCdn()
+        {
+            string actual = m_api.UrlImgUp.Suffix("hello").Signed(true).Format("jpg").BuildUrl("test");
+            Assert.AreEqual("http://res.cloudinary.com/testcloud/images/s--1TMilNWq--/test/hello.jpg", actual);
+        }
+
         [Test]
         public void TestResponsiveWidthTransform()
         {

diff --git a/Cloudinary/Url.cs b/Cloudinary/Url.cs
@@ -492,8 +492,8 @@ public string BuildUrl(string source)
             if (String.IsNullOrEmpty(m_cloudName))
                 throw new ArgumentException("cloudName must be specified!");
 
-            if (!m_usePrivateCdn && !String.IsNullOrEmpty(m_suffix))
-                throw new NotSupportedException("URL Suffix only supported in private CDN!");
+            //if (!m_usePrivateCdn && !String.IsNullOrEmpty(m_suffix))
+                //throw new NotSupportedException("URL Suffix only supported in private CDN!");
 
             if (source == null)
                 source = m_source;