Add automatic PR checks #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds automatic checks for each PR:
* `cargo clippy`
* `cargo fmt` (checks that `cargo fmt` is a no-op)
* [`cargo msrv`] (verifies that minimum supported Rust version is what
is set as `rust-version` in Cargo.toml)
* `cargo test`
This also sets GitHub’s dependabot to check for updates to the GitHub
actions used monthly.
Currently, the crate works on any version of Rust from 1.56 on up. This
sets `rust-version` in Cargo.toml so that any change to the minimum
supported Rust version (MSRV) will be noticed.
Finally, this removes the rust-toolchain file and adds it to .gitignore.
This allows the crate to be developed on any version of Rust ≥1.56.
Fixes: cloudhead#17 — Set up continious integration
[`cargo msrv`]: https://github.com/foresterre/cargo-msrv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds automatic checks for each PR:
cargo clippycargo fmt(checks thatcargo fmtis a no-op)cargo msrv(verifies that minimum supported Rust version is what is set asrust-versionin Cargo.toml)cargo testThis also sets GitHub’s dependabot to check for updates to the GitHub actions used monthly.
Currently, the crate works on any version of Rust from 1.56 on up. This sets
rust-versionin Cargo.toml so that any change to the minimum supported Rust version (MSRV) will be noticed.Finally, this removes the rust-toolchain file and adds it to .gitignore. This allows the crate to be developed on any version of Rust ≥1.56.
Fixes: #17 — Set up continious integration
This is close to what I use in my crates1, so it was easy to adapt. If you don’t like it at all, it’s no problem to just discard. (Or modify, of course.)
Footnotes
I also use cargo-deny to check dependencies for security vulnerabilities and license problems, but given that the only dependency is libc that seems a little silly. Still, I could add it without any real effort. ↩