Add property resolution for provided dependencies #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radito3
reviewed
Oct 11, 2023
|
|
||
| import org.cloudfoundry.multiapps.common.ContentException; | ||
| import org.cloudfoundry.multiapps.mta.Messages; | ||
| import org.cloudfoundry.multiapps.mta.handlers.v2.DescriptorHandler; |
| @@ -77,4 +80,20 @@ protected RequiredDependencyReferenceResolver createRequiredDependencyResolver(R | |||
| dynamicResolvableParameters); | |||
| } | |||
|
|
|||
| protected ProvidedDependencyReferenceResolver getProvidedDependencyResolver(ProvidedDependency providedDependency) { | |||
| import java.util.Set; | ||
|
|
||
| import org.cloudfoundry.multiapps.common.ContentException; | ||
| import org.cloudfoundry.multiapps.mta.handlers.v2.DescriptorHandler; |
| this.dependency = dependency; | ||
| this.propertiesResolverBuilder = propertiesResolverBuilder; | ||
| this.handler = handler; | ||
| this.consumerName = container.getName(); |
There was a problem hiding this comment.
container is a bit hard to understand here. Maybe parent? Or sticking with the class field name, maybe consumer?
vkalapov
force-pushed
the
add-provided-property-resolution
branch
from
5baf3b8
to
222583a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
radito3
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: LMCROSSITXSADEPLOY-2798