Repository navigation
Conversation
LMCROSSITXSADEPLOY-3312
|
Yavor16
requested changes
Nov 10, 2026
Comment on lines
+70
to
+71
| String region = ((String) credentials.get(CredentialKeys.REGION)).substring( | ||
| 4); // so we can remove the "oss-" part, because it does not work with V4 signing |
Contributor
There was a problem hiding this comment.
If we receive something other than oss- this will break. Can you use replace("oss-", "")
Comment on lines
+76
to
+79
| config.setConnectionTimeout((int) ObjectStoreConstants.ALI_OBJECT_STORE_CONNECTION_TIMEOUT_CONFIG_IN_SECONDS.toMillis()); | ||
| config.setSocketTimeout((int) ObjectStoreConstants.ALI_OBJECT_STORE_SOCKET_TIMEOUT_CONFIG_IN_MINUTES.toMillis()); | ||
| config.setRequestTimeoutEnabled(true); | ||
| config.setRequestTimeout((int) ObjectStoreConstants.ALI_OBJECT_STORE_REQUEST_TIMEOUT_CONFIG_IN_MINUTES.toMillis()); |
| LOGGER.debug(MessageFormat.format(Messages.DELETED_FILE_WITH_ID_0_AND_SPACE_1, id, space)); | ||
| } catch (OSSException | ClientException e) { | ||
| LOGGER.error(MessageFormat.format(Messages.ALI_OBJECT_STORE_OPERATION_0_FAILED_FOR_KEY_1, "deleteObject", id, describe(e))); | ||
| throw e; |
Contributor
There was a problem hiding this comment.
Throw FileStorageException not the incomming one
| } catch (OSSException | ClientException e) { | ||
| LOGGER.error(MessageFormat.format(Messages.ALI_OBJECT_STORE_CONNECTION_TEST_FAILED_FOR_BUCKET_0_ENDPOINT_1, bucketName, | ||
| endpoint, describe(e))); | ||
| throw e; |
Contributor
There was a problem hiding this comment.
throw FileStorageException
| ossObject = ossClient.getObject(request); | ||
| } catch (OSSException | ClientException e) { | ||
| LOGGER.error(MessageFormat.format(Messages.ALI_OBJECT_STORE_OPERATION_0_FAILED_FOR_KEY_1, "getObject", id, describe(e))); | ||
| throw e; |
Contributor
There was a problem hiding this comment.
throw FileStorageException
| } while (listing.isTruncated()); | ||
| } catch (OSSException | ClientException e) { | ||
| LOGGER.error(MessageFormat.format(Messages.ALI_OBJECT_STORE_LISTING_FAILED_FOR_BUCKET_0, bucketName, describe(e))); | ||
| throw e; |
Contributor
There was a problem hiding this comment.
throw FileStorageException
Comment on lines
+115
to
+119
| ObjectMetadata metadata = new ObjectMetadata(); | ||
| metadata.setContentLength(fileSize); | ||
| metadata.setContentType(MediaType.APPLICATION_OCTET_STREAM_VALUE); | ||
| metadata.setContentDisposition(fileEntry.getName()); | ||
| metadata.setUserMetadata(ObjectStoreMapper.createFileEntryMetadata(fileEntry)); |
Contributor
There was a problem hiding this comment.
i would separate it to a new method because this a long method
Comment on lines
+276
to
+282
| .map(objectSummary -> CompletableFuture.supplyAsync(() -> fetchMetadataAndFilter(objectSummary.getKey(), predicate), | ||
| executor)) | ||
| .toList() | ||
| .stream() | ||
| .map(CompletableFuture::join) | ||
| .filter(Objects::nonNull) | ||
| .toList(); |
Contributor
There was a problem hiding this comment.
why dont you do the second map right after the first one instead calling toList?
Comment on lines
+337
to
+342
| try { | ||
| do { | ||
| listing = ossClient.listObjects(request); | ||
| pageConsumer.accept(listing.getObjectSummaries()); | ||
| request.setMarker(listing.getNextMarker()); | ||
| } while (listing.isTruncated()); |
Contributor
There was a problem hiding this comment.
Separate the do-while in a new method because there are nested structures.
P.S wow, haven't seen do-while in a while. no pun intended :D
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrating from JClouds OS to AliCloud OS
LMCROSSITXSADEPLOY-3312