Replacing validate uniqueness with db constraint on Sidecar model#4954
Open
serdarozerr wants to merge 2 commits intocloudfoundry:mainfrom
Open
Conversation
- db migration added on columns app_guid and name. Unit testting added too - sequel validate uniqueness removed from model and around save added instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the Sequel
validates_uniquecheck with a DB-level unique index on(app_guid, name)for thesidecarstable. Thearound_savehook catchesUniqueConstraintViolationand converts it toValidationFailed, making uniqueness enforcement race-condition safe.Changes
sidecars_app_guid_name_indexunique constraint (idempotent, with guard check before adding)validates_unique [:app_guid, :name], addedaround_savefor DB-level enforcement with a user-friendly error messagearound_saveI have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests