Fix race condition when deleting labels#4944
Open
philippthun wants to merge 1 commit intocloudfoundry:mainfrom
Open
Fix race condition when deleting labels#4944philippthun wants to merge 1 commit intocloudfoundry:mainfrom
philippthun wants to merge 1 commit intocloudfoundry:mainfrom
Conversation
Concurrent requests updating the same resource's labels could fail with
Sequel::NoExistingObject when both try to delete the same label. This
occurred because find().destroy loads the model first, then deletes by
ID - if another request deletes it in between, the delete affects 0 rows
and Sequel raises an error.
Changed to use where().destroy which deletes directly via SQL without
loading the model, making it atomic and idempotent.
Also removed unnecessary .try(:destroy) from annotations_update since
where() always returns a dataset, never nil.
Observed error:
CF-NoExistingObject: Attempt to delete object did not result in a single
row modification (Rows Deleted: 0, SQL: DELETE FROM
"service_instance_labels" WHERE ("id" = ...))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent requests updating the same resource's labels could fail with
Sequel::NoExistingObjectwhen both try to delete the same label. This occurred becausefind().destroyloads the model first, then deletes by ID - if another request deletes it in between, the delete affects 0 rows and Sequel raises an error.Changed to use
where().destroywhich deletes directly via SQL without loading the model, making it atomic and idempotent.Also removed unnecessary
.try(:destroy)fromannotations_updatesincewhere()always returns a dataset, nevernil.Observed error:
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests