Reload process to use DB-assigned updated_at timestamps#4935
Open
philippthun wants to merge 1 commit intocloudfoundry:mainfrom
Open
Reload process to use DB-assigned updated_at timestamps#4935philippthun wants to merge 1 commit intocloudfoundry:mainfrom
philippthun wants to merge 1 commit intocloudfoundry:mainfrom
Conversation
philippthun
force-pushed
the
fix-process-observer-updated-at-drift
branch
from
55ab2a2 to
6b7fb87
Compare
philippthun
changed the title
When a process is saved, Sequel's timestamps plugin sets updated_at in-memory before the DB transaction commits. If the runner is called after the transaction commits (via after_commit callback), it receives a stale in-memory timestamp that may differ from the DB-assigned value. ProcessesSync compares process.updated_at against the LRP annotation to detect drift. A stale timestamp causes unnecessary re-sync requests. This commit adds process.reload before passing the process to runners in ProcessObserver, ProcessRouteHandler, and AppUpdate. This ensures the runner receives the DB-assigned timestamp. Also removes an incorrect comment in ProcessRestart about timestamp precision differences - testing confirmed the timestamps match when the runner is called inside the transaction. Adds skip_process_observer_on_update in AppUpdate to prevent redundant ProcessObserver.updated calls when metric tags are being updated.
philippthun
force-pushed
the
fix-process-observer-updated-at-drift
branch
from
6b7fb87 to
f1bd777
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a process is saved, Sequel's timestamps plugin sets
updated_atin-memory before the DB transaction commits. If the runner is called after the transaction commits (viaafter_commitcallback), it receives a stale in-memory timestamp that may differ from the DB-assigned value.ProcessesSynccomparesprocess.updated_atagainst the LRP annotation to detect drift. A stale timestamp causes unnecessary re-sync requests.This commit adds
process.reloadbefore passing the process to runners inProcessObserver,ProcessRouteHandler, andAppUpdate. This ensures the runner receives the DB-assigned timestamp.Also removes an incorrect comment in
ProcessRestartabout timestamp precision differences - testing confirmed the timestamps match when the runner is called inside the transaction.Adds
skip_process_observer_on_updateinAppUpdateto prevent redundantProcessObserver.updatedcalls when metric tags are being updated.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests