Improve error handling for already deleted resources#4352
Merged
philippthun merged 4 commits intomainfrom May 13, 2025
Merged
Conversation
If a user triggers two DELETE requests for the same resource within a few milliseconds two deletion jobs are created. If both jobs are be executed in parallel it might happen that one of them fails with a `Sequel::NoExistingObject` error. This change prevents this by catching those errors but only if the error message originates from the current model/ table. Therefore it is ensured that similar error messages when e.g. deleting sub resources still result in job failures. The same applies if a user unbind routes but also deletes the route itself within a very short time period. For this case the route model now also catches `Sequel::NoExistingObject` errors related to route bindings. Additionally, the error handling in the DeleteActionJob was improved to catch errors when the actions itself don't handle them.
Otherwise it might return a dataset.
johha
force-pushed
the
already-deleted-resources
branch
from
41755b9 to
b20fd02
Compare
nookala
approved these changes
May 12, 2025
philippthun
reviewed
May 13, 2025
philippthun
approved these changes
May 13, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
May 13, 2025
Changes in cloud_controller_ng:
- Improve error handling for already deleted resources
PR: cloudfoundry/cloud_controller_ng#4352
Author: Johannes Haass <johannes.haass@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user triggers two DELETE requests for the same resource within a few milliseconds two deletion jobs are created. If both jobs are be executed in parallel it might happen that one of them fails with a
Sequel::NoExistingObjecterror. This change prevents this by catching those errors but only if the error message originates from the current model/ table. Therefore it is ensured that similar error messages when e.g. deleting sub resources still result in job failures.The same applies if a user unbind routes but also deletes the route itself within a very short time period. For this case the route model now also catches
Sequel::NoExistingObjecterrors related to route bindings.Additionally, the error handling in the DeleteActionJob was improved to catch errors when the actions itself don't handle them.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests