Merged
Conversation
With this change the retry-after header will be treated as an absolute value and not used for exponential backoff. Whenever the retry-after interval sent by the service broker is larger than the calculated interval using the base interval and exponential backoff, the retry-after interval will be used. When the CC calculated interval is larger the retry-after interval will be ignored.
svkrieger
force-pushed
the
enhance-sb-polling-intervals
branch
3 times, most recently
from
415219a to
be56e86
Compare
3 tasks
The maximum polling interval was hardcoded to 24h when set on the job. Though, the exponential backoff calculation did not take this into account. Now the maximum can be configured through `broker_client_maximum_async_poll_interval_seconds` and will be taken into account for all scenarios. Default is still 24h and the config is optional.
svkrieger
force-pushed
the
enhance-sb-polling-intervals
branch
from
be56e86 to
47ef7e9
Compare
Contributor
|
jochenehret
approved these changes
May 6, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
May 6, 2025
Changes in cloud_controller_ng:
- Enhance SB polling intervals
PR: cloudfoundry/cloud_controller_ng#4328
Author: Sven Krieger <37476281+svkrieger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Currently the retry-after header is used in the exponential backoff calculation. This PR makes it more intuitive by using the retry-after value as is, if it is larger than our own calculated polling interval. With that service owners can defer polling when they know that provisioning takes longer.
Introducing a configuration parameter
broker_client_max_async_poll_interval_secondsfor capping the polling interval. This helps preventing that polling intervals get too large. Default is still at 24h, which was hardcoded before.Links to any other associated PRs
cloudfoundry/capi-release#542
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests