[v8][cherry-pick] Fix(ci): fix delete-env failures and add force-delete fallback#3822
Open
prkalle wants to merge 1 commit into
Open
[v8][cherry-pick] Fix(ci): fix delete-env failures and add force-delete fallback#3822prkalle wants to merge 1 commit into
prkalle wants to merge 1 commit into
Conversation
bosh delete-deployment used an invalid --skip-drain flag, causing it to silently fail every run and leaving bbl down to hit "umount: target is busy" during its own deployment teardown. Fix the flag and add a force-delete-env.sh fallback that tears down the director/jumpbox directly via the GCP CPI when the graceful path can't recover (e.g. abandoned BOSH tasks or a stuck task worker). Signed-off-by: Prem Kumar Kalle <prem.kalle@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR cherry-pick of #3819
This PR fixes delete-env failures during CI teardown. This PR fixes adds a force-delete fallback that tears down the environment directly via the GCP CPI when the graceful path still can't recover (e.g. an unresponsive director).
Why Is This PR Valuable?
It prevents resource leaks that were silently accumulating cost every time delete-env failed to fully tear down a test environment.
Applicable Issues
List any applicable GitHub Issues here
How Urgent Is The Change?
moderately urgent
Other Relevant Parties