[v8][cherry-pick] Fix(ci): allow checkout of gated PR head SHA under actions/checkout#3821
Open
prkalle wants to merge 1 commit into
Open
[v8][cherry-pick] Fix(ci): allow checkout of gated PR head SHA under actions/checkout#3821prkalle wants to merge 1 commit into
prkalle wants to merge 1 commit into
Conversation
|
|
actions/checkout v7 now refuses to check out a pull_request_target ref other than the safe default, to block pwn-request attacks. Our checkouts of needs.get-sha.outputs.gitRef / inputs.gitRef are already gated by get-sha's author-association and safe-to-test label checks, so opt back in with allow-unsafe-pr-checkout: true on those two steps. Signed-off-by: Prem Kumar Kalle <prem.kalle@broadcom.com>
prkalle
force-pushed
the
fix/checkout_pr_ref_v8
branch
from
b2f299a to
4cfb7f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR is cherry-pick of #3820
This PR fixes CI for integration tests by allowing checkout of gated PR head SHA under actions/checkout
Why Is This PR Valuable?
Fixes CI
Applicable Issues
How Urgent Is The Change?
Fairly urgent to fix the CI
Other Relevant Parties
Who else is affected by the change?