remove ruby 3.3 package

[aramprice]

• remove spec complexity for ruby 3.3 + 3.4 support

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[coderabbitai]

Walkthrough

The SourceErb unit spec is updated to replace regex-based and Ruby-version-dependent error message assertions with exact string matches. The original_error variable is set to a fixed string "undefined method 'no_method' for nil", and the expected template error message and logger debug assertion are both changed from regex patterns to exact string comparisons.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title mentions removing the Ruby 3.3 package, but the diff only adjusts a unit spec for ERB error-message expectations.	Rename the title to reflect the actual spec change, e.g. updating SourceErb error-message expectations.
Description check	⚠️ Warning	The description is far too sparse and omits the required template sections for context, tests, release notes, breaking change, and tags.	Fill in all template sections with the change summary, context, tests run, release-note text, breaking-change impact, and team tags.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch remove-ruby-3.3

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/bosh-director/spec/unit/bosh/director/core/templates/source_erb_spec.rb`:
- Around line 39-46: The spec for SourceErb#render is too strict about
Ruby-generated NoMethodError text; keep the exact assertion for the wrapper
message built from expected_message, but relax the exception text check in the
logger expectation that uses logger.debug and NoMethodError#inspect. Update the
example in source_erb_spec to match the error object more generally (rather than
exact undefined method text) while still verifying that SourceErb#render logs
the original backtrace and the wrapped "Error filling in template ..." message.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 474d6e09-26f0-4b13-80e2-ca71547c4699

📥 Commits

Reviewing files that changed from the base of the PR and between e2f4965 and 4bf14e4.

⛔ Files ignored due to path filters (1)

• packages/director-ruby-3.3/spec.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

• src/bosh-director/spec/unit/bosh/director/core/templates/source_erb_spec.rb

[aramprice]

Holding of on merging until the resolute changes (bosh workers use bpm) which are causing issues with warden-cpi[1] are resolved

1. https://bosh.ci.cloudfoundry.org/teams/main/pipelines/bosh-director/jobs/bosh-disaster-recovery-acceptance-tests