Remove -z flag from validate_tgz in package_persister#2695
Merged
aramprice merged 1 commit intocloudfoundry:mainfrom Mar 18, 2026
Merged
Remove -z flag from validate_tgz in package_persister#2695aramprice merged 1 commit intocloudfoundry:mainfrom
aramprice merged 1 commit intocloudfoundry:mainfrom
Conversation
Follow-up to PR cloudfoundry#2635 which removed the -z flag from tar extraction commands but missed the validate_tgz method in package_persister.rb and its corresponding test expectations. The -z flag forces gzip decompression, causing failures when processing non-gzip-compressed package archives. Modern tar auto-detects the compression format without needing the -z flag. Made-with: Cursor
Contributor
Author
|
@rkoster @aramprice can you folks please merge this with priority? Thanks! |
aramprice
approved these changes
Mar 18, 2026
Member
|
Hi @mdzhigarov - this looks small, happy to merge. Have you already done a deeper search in the codebase to see if there are any more lurking |
Contributor
Author
Yes, ran a cursor agent to find other occurrences. Seems this is the only one... Not sure how I've missed it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2635 which removed the
-zflag from tar extraction commands but missed:validate_tgzmethod inpackage_persister.rb(tar -tzf→tar -tf)package_persister_spec.rbThe
-zflag forces gzip decompression, causinggzip: stdin: not in gzip formatfailures when processing non-gzip-compressed package archives (e.g. uncompressed tarballs). Modern tar auto-detects the compression format without needing the-zflag.Changes
package_persister.rbtar -tzf→tar -tfinvalidate_tgzpackage_persister_spec.rb