Extend bosh tagging for cpi #2603
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR for the cpi changes will follow. |
fmoehler
reviewed
Feb 11, 2025
| @@ -109,7 +109,16 @@ def perform | |||
| upload_suffix = ' (already exists, skipped)' unless needs_upload | |||
| track_and_log("Uploading stemcell #{@name}/#{@version} to the cloud#{cpi_suffix}#{upload_suffix}") do | |||
| if needs_upload | |||
| stemcell.cid = cloud.create_stemcell(@stemcell_image, @cloud_properties) | |||
| tags = {} | |||
There was a problem hiding this comment.
Can we put this part in a separate method?
There was a problem hiding this comment.
You mean like get_tags() returning the tags hash?
There was a problem hiding this comment.
yeah something like that would be nice I think, what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
This change provides the default runtime tags to the upload stemcell cpi call. With this a stemcell can be tagged when it is uploaded.
Please provide contextual information.
We wanted to have a possibility to tag all relevant and "bound" resources. With tags clean ups of cloud resources is much easier because it is clear which resources belong together and have certain tags how to handle them. In this PR we want to provide the tags for the cpi.
What tests have you run against this PR?
Unit tests
How should this change be described in bosh release notes?
Provides default runtime tags to the cpi when a stemmcell is created.
Does this PR introduce a breaking change?
No
Tag your pair, your PM, and/or team!
@anshrupani, @fmoehler