Relax hostonly net create #36
Draft
+237
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the arguments in the Vbox v[56].* case
As they say, they have a special requirement for limiting network masks to 2^16 allocatable IPs only: // For IPv6, the max size will be limited to 65536 // This is due to the allocator keeping track of all the // allocated IP's in a bitmap. This will keep the size of // the bitmap to 64k. Ref: https://github.com/tkestack/tke/blob/v1.9.2/pkg/util/ipallocator/allocator.go#L271-L274 But here there in the VirtualBox CPI is no reason for such a limitation. We just need the correct calculation of mask length.
With VirtualBox v7 on macOS we can create networks of 'hostonlynets' with a new CLI experience that allows any name for the created network. We leverage this new possibility, while still retaining the former feature with networks of 'hostonlyif' type, when the name of a non-existing and to-be-created network could possibly be guessed in advance, and if correctly guessed, then everything was fine.
bgandon
force-pushed
the
relax-hostonly-net-create
branch
from
067e2cd
to
d7c74ba
Compare
bgandon
force-pushed
the
relax-hostonly-net-create
branch
from
d7c74ba
to
6491479
Compare
rkoster
requested review from
a team,
cunnie and
ramonskie
and removed request for
a team
|
As told last week, I'll test this soon and document the test case, even if manual |
|
@bgandon How did the testing go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite anti-patterns introduced in #31.
Fixes #34.