Skip to content

Adapt bosh-package to include all schema-files; #3995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joergdw merged 8 commits into from
Dec 17, 2025
Merged

Adapt bosh-package to include all schema-files; #3995

joergdw merged 8 commits into from
Dec 17, 2025

Conversation

@joergdw
Copy link
Contributor

@joergdw joergdw commented Dec 11, 2025 •
edited
Loading

This PR complements cloudfoundry/app-autoscaler#867 which makes changes to the json-schema-files by doing the necessary adaptions to the bosh-packages.

bonzofenix
bonzofenix requested changes Dec 11, 2025
View reviewed changes
Copy link
Contributor

@bonzofenix bonzofenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we revert the submodule before merging? other than that it looks good to me

@joergdw joergdw force-pushed the include_schema-files branch from 404f64c to 39a401f Compare December 12, 2025 12:48
@joergdw joergdw marked this pull request as ready for review December 17, 2025 03:56
@joergdw
Copy link
Contributor Author

joergdw commented Dec 17, 2025

can we revert the submodule before merging? other than that it looks good to me
Fine, but lets first run the checks until everything is green. Because the tests will fail when the submodule is set back.

So I then need to merge with red tests.

@joergdw
Copy link
Contributor Author

joergdw commented Dec 17, 2025

Regarding the failure Specs are out of date, run "make package-specs" to update, see logs, following that advice will do harm: It proposes the change

-- autoscaler/api/policyvalidator/** # gosub
+- autoscaler/api/policyvalidator/* # gosub

which will lead to missing files.

@joergdw joergdw force-pushed the include_schema-files branch from 1ecd4ce to c149baa Compare December 17, 2025 07:42
@joergdw joergdw force-pushed the include_schema-files branch from c149baa to 61fd54f Compare December 17, 2025 07:55
bonzofenix
bonzofenix approved these changes Dec 17, 2025
View reviewed changes
Copy link
Contributor

@bonzofenix bonzofenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,lets revert the submodule before merging

@joergdw
Copy link
Contributor Author

joergdw commented Dec 17, 2025

Tests are green. I now switch the submodule-reference (which will cause tests to fail) and merge anyway.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 17, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@joergdw joergdw merged commit e173eb1 into main Dec 17, 2025
8 of 9 checks passed
@joergdw joergdw deleted the include_schema-files branch December 17, 2025 10:56
@joergdw joergdw mentioned this pull request Dec 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bonzofenix bonzofenix bonzofenix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joergdw @bonzofenix