json-schema-refactoring #3939
Merged
json-schema-refactoring #3939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joergdw
force-pushed
the
json-schema-refactoring
branch
2 times, most recently
from
0eb356a to
300eaca
Compare
joergdw
force-pushed
the
json-schema-refactoring
branch
from
d1d1552 to
0634a3e
Compare
joergdw
force-pushed
the
json-schema-refactoring
branch
from
9930f88 to
f102249
Compare
joergdw
commented
Oct 14, 2025
joergdw
force-pushed
the
json-schema-refactoring
branch
from
76f181c to
cb8652f
Compare
|
Added not-merge-lable to align on the release this should go in. |
silvestre
requested changes
Oct 20, 2025
There was a problem hiding this comment.
LGTM, with two main points:
- Since we decided not to bring in a second binding schema for now, I would suggest not renaming the current schema to
legacyto not cause confusion. - If possible not duplicate the binding schema definition in two places. As it is not exported I think it can stay where it currently is without a copy in
schema/.
Co-authored-by: Silvestre Zabala <[email protected]>
Co-authored-by: Silvestre Zabala <[email protected]>
|
File-renamings done! |
silvestre
approved these changes
Oct 21, 2025
silvestre
reviewed
Oct 21, 2025
src/autoscaler/api/publicapiserver/publicapiserver_suite_test.go
Outdated
Show resolved
Hide resolved
silvestre
reviewed
Oct 21, 2025
joergdw
force-pushed
the
json-schema-refactoring
branch
from
6393018 to
8178d7d
Compare
|
All tests are green now and reviewer approval is there. I now remove the todo-item from templates/app-autoscaler.yml. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
app-guidwhich is a prerequisite to support service-keys.