Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wrangler): Add Bulk Key Get command to KV #8620

Merged
merged 17 commits into from
Mar 26, 2025
Merged

Conversation

pmiguel
Copy link
Contributor

@pmiguel pmiguel commented Mar 21, 2025

Fixes KV-1434

Adds support for bulk reading values from namespaces.

Covered by CR-1138428

Screenshot 2025-03-26 at 10 40 13
  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: New functionality

Copy link

changeset-bot bot commented Mar 21, 2025

🦋 Changeset detected

Latest commit: fd1e6c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pmiguel pmiguel force-pushed the pleal/kv-bulk-get branch 6 times, most recently from 632032e to 6e69996 Compare March 24, 2025 10:31
Copy link
Contributor

github-actions bot commented Mar 24, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14059074312/npm-package-wrangler-8620

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8620/npm-package-wrangler-8620

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14059074312/npm-package-wrangler-8620 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14059074312/npm-package-cloudflare-workers-bindings-extension-8620 -O ./cloudflare-workers-bindings-extension.0.0.0-v3ef32e585.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v3ef32e585.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14059074312/npm-package-create-cloudflare-8620 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14059074312/npm-package-cloudflare-kv-asset-handler-8620

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14059074312/npm-package-miniflare-8620

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14059074312/npm-package-cloudflare-pages-shared-8620

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14059074312/npm-package-cloudflare-unenv-preset-8620

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14059074312/npm-package-cloudflare-vite-plugin-8620

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14059074312/npm-package-cloudflare-vitest-pool-workers-8620

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14059074312/npm-package-cloudflare-workers-editor-shared-8620

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14059074312/npm-package-cloudflare-workers-shared-8620

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14059074312/npm-package-cloudflare-workflows-shared-8620

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250320.0
workerd 1.20250321.0 1.20250321.0
workerd --version 1.20250321.0 2025-03-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@pmiguel pmiguel force-pushed the pleal/kv-bulk-get branch 4 times, most recently from 879a792 to 3811aa7 Compare March 24, 2025 11:42
@pmiguel pmiguel added the e2e Run wrangler e2e tests on a PR label Mar 24, 2025
@pmiguel pmiguel force-pushed the pleal/kv-bulk-get branch from 3811aa7 to d26a73c Compare March 24, 2025 12:02
@pmiguel pmiguel marked this pull request as ready for review March 24, 2025 12:21
@pmiguel pmiguel requested review from a team as code owners March 24, 2025 12:21
@pmiguel pmiguel force-pushed the pleal/kv-bulk-get branch from d26a73c to c36a87d Compare March 24, 2025 13:13
@pmiguel pmiguel force-pushed the pleal/kv-bulk-get branch 2 times, most recently from d60cd0c to 88cfb60 Compare March 24, 2025 17:34
@pmiguel pmiguel force-pushed the pleal/kv-bulk-get branch from 88cfb60 to da216ab Compare March 24, 2025 17:40
@pmiguel pmiguel requested review from emily-shen and rts-rob March 24, 2025 17:53
@pmiguel pmiguel force-pushed the pleal/kv-bulk-get branch from da216ab to fa9e51c Compare March 24, 2025 18:19
@CarmenPopoviciu
Copy link
Contributor

LGTM! I'll hold off approving until the CR is approved. Once that's in, I'll merge and this should go out with today's release

@CarmenPopoviciu
Copy link
Contributor

CR is approved! This PR is now pending on some API changes being released. Holding off approval until that release goes out

Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much for working on this <3

@CarmenPopoviciu CarmenPopoviciu merged commit 14602d9 into main Mar 26, 2025
22 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the pleal/kv-bulk-get branch March 26, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants