feat: implement local dev for ctx.access - #15113
Conversation
🦋 Changeset detectedLatest commit: 28bcd33 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cdaeef8 to
1fc454f
Compare
|
Codeowners approval required for this PR:
Show detailed file reviewers |
1fc454f to
6ff008b
Compare
6ff008b to
440e3dc
Compare
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
440e3dc to
584517d
Compare
3e0ca21 to
ff503a4
Compare
petebacondarwin
left a comment
There was a problem hiding this comment.
Looking good so far. Please can you address the Devin comments, which seem valid.
There was a problem hiding this comment.
How come there are so many changes to this generated file??
There was a problem hiding this comment.
needed new changes in workerd so regenerated this file. after a quick scan, seems to be the access blob header and a few deprecation renamings. let me know if anything looks wrong!
(i regenerated again a few minutes ago because i was having some issues with node versions a little bit ago, so hopefully it looks good now!)
7439059 to
91bce65
Compare
91bce65 to
2d81818
Compare
Signed-off-by: Matt Provost <mprovost@cloudflare.com>
2d81818 to
28bcd33
Compare
|
We should probably block this PR on #15131 |
petebacondarwin
left a comment
There was a problem hiding this comment.
Assuming the CI jobs are happy.
|
I assume CI will fail due to the changes needed to land the latest workerd with the default nodejs_compat change. |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Fixes AUTH-8942.
Adds support for mocking
ctx.accesslocally for development. Currently we just mock static values although the infrastructure is there to eventually pull real info from production Access or enhance with a more sophisticated mock.wrangler.jsonc{ "access": { "dev": { "aud": "my-app-aud-tag", "identity": { "email": "user@example.com", "name": "Test User" } } } }obligatory cat picture