Skip to content

[wrangler] Enable new config for cf dev - #15082

Open
penalosa wants to merge 1 commit into
mainfrom
penalosa/migration
Open

[wrangler] Enable new config for cf dev#15082
penalosa wants to merge 1 commit into
mainfrom
penalosa/migration

Conversation

@penalosa

@penalosa penalosa commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Projects started through cf dev now enable Wrangler's new configuration format, so dev loads cloudflare.config.ts and optional wrangler.config.ts in the same way as the delegate's build path.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: this forwards an existing, tested Wrangler option; the existing 26 cf-wrangler tests pass.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this aligns the experimental delegate's dev and build configuration behaviour.

A picture of a cute animal (not mandatory, but encouraged)


Open in Devin Review

@changeset-bot

changeset-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0f9c317

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Aug 7, 2026
@workers-devprod
workers-devprod requested review from a team and edmundhung and removed request for a team August 7, 2026 16:39
@workers-devprod

workers-devprod commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

✅ All changesets look good

@ask-bonk

ask-bonk Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

The plumbing is consistent: experimentalNewConfig flows from the options literal → startDev → ConfigController, gating the new-config load path. The change is minimal, coherent, and aligns dev with the already-new-config build path in the same experimental delegate.

I reviewed the change thoroughly:

  • The single functional change adds experimentalNewConfig: true to the dev options literal, alongside the existing config: undefined (so the --config-not-supported guard in readNewConfig is satisfied).
  • The option is correctly consumed via args.experimentalNewConfig in start-dev.ts:279 → ConfigController.
  • Behavior now requires cloudflare.config.ts, but this matches the build verb (which already forces the new-config BOS path) — intentional and consistent for this experimental delegate.
  • Changeset is present, correctly scoped to wrangler as a patch.
  • No existing tests assert against the old options shape.

No logic bugs, security issues, backward-compat violations, or incorrect API behavior. This is a small, well-scoped, internally consistent change.

LGTM

github run

devin-ai-integration[bot]

This comment was marked as resolved.

@pkg-pr-new

pkg-pr-new Bot commented Aug 7, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15082

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15082

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15082

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15082

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15082

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15082

miniflare

npm i https://pkg.pr.new/miniflare@15082

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15082

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15082

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15082

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15082

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@15082

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15082

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15082

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15082

wrangler

npm i https://pkg.pr.new/wrangler@15082

commit: 0f9c317

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Aug 11, 2026
@penalosa
penalosa force-pushed the penalosa/migration branch from ad99454 to dbe5f43 Compare August 11, 2026 16:58
@penalosa
penalosa enabled auto-merge (squash) August 11, 2026 16:59
@penalosa
penalosa force-pushed the penalosa/migration branch from dbe5f43 to 0f9c317 Compare August 11, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

3 participants