Skip to content

[workers-auth] Avoid stale Access service-token headers - #15080

Open
teamleaderleo wants to merge 1 commit into
cloudflare:mainfrom
teamleaderleo:fieldwork/529-access-current-repair
Open

[workers-auth] Avoid stale Access service-token headers#15080
teamleaderleo wants to merge 1 commit into
cloudflare:mainfrom
teamleaderleo:fieldwork/529-access-current-repair

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Aug 7, 2026

Copy link
Copy Markdown

Fixes #15070

getAccessHeaders() stored Access service-token headers in the domain cache. If the current CLOUDFLARE_ACCESS_CLIENT_ID / CLOUDFLARE_ACCESS_CLIENT_SECRET pair was later removed or became incomplete, a later call for the same domain could reuse the earlier complete pair.

This change returns service-token headers directly from the current environment instead of storing them in the domain cache. Interactive CF_Authorization cookie caching is unchanged.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this only corrects reuse of existing Access service-token environment variables and does not add or change user-facing configuration.

Japanese dwarf flying squirrel peeking out of tree:
image


Open in Devin Review

@changeset-bot

changeset-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c96c479

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cloudflare/workers-auth Patch
@cloudflare/remote-bindings Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod
workers-devprod requested review from a team and jamesopstad and removed request for a team August 7, 2026 16:16
@workers-devprod

workers-devprod commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@petebacondarwin
petebacondarwin removed the request for review from jamesopstad August 10, 2026 08:38
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Aug 10, 2026

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Aug 10, 2026
@pkg-pr-new

pkg-pr-new Bot commented Aug 10, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15080

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15080

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15080

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15080

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15080

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15080

miniflare

npm i https://pkg.pr.new/miniflare@15080

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15080

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15080

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15080

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15080

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@15080

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15080

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15080

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15080

wrangler

npm i https://pkg.pr.new/wrangler@15080

commit: c96c479

@petebacondarwin
petebacondarwin force-pushed the fieldwork/529-access-current-repair branch from 8412e9a to c96c479 Compare August 12, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

Access service-token headers can remain after environment credentials change

3 participants