Support eager memory deallocation on hibernation #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Unfortunately this fails because destroying the last instance when a new instance is constructed doesn't work since it seems we support constructing multiple in the same isolate of a given durable object. |
|
It turns out this requires upstream work to properly support, given the multi-DO handling. |
|
An upstream change for an unload event is posted in cloudflare/workerd#5211. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While formally not a memory leak, this reduces Wasm memory usage for durable objects subject to hibernation by eagerly freeing Wasm memory associated with the stale instance when a new instance is constructed.