Remove unnecessary Copy constraint on durable::Storage::transaction()
#710
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
durable::Storage::transaction
requires that its closure implementCopy
. This is way too strong a requirement, since you can't even do things like:The compiler yells, saying
the trait bound String: std::marker::Copy is not satisfied in {closure@...}
.Fortunately, there's no inherent reason why this closure needs to implement
Copy
. This PR changes the transaction semantics to make use ofwasm_bindgen
's built-inFnOnce
support for futures.