[WIP] Attempt to reproduce Windows compiler crashes#6416
[WIP] Attempt to reproduce Windows compiler crashes#6416
Conversation
.bazelrc
Outdated
| # Ref: https://github.com/llvm/llvm-project/issues/136481 | ||
| build:release_windows --per_file_copt=.*capnp/rpc\.c++@/clang:-O1 | ||
| build:windows --@capnp-cpp//src/kj:debug_memory=False | ||
| build:windows --per_file_copt=.*capnp/rpc\.c++@"/O2,/Gy,/Gw,-fstrict-aliasing,/clang:-O3 |
There was a problem hiding this comment.
Unmatched quote: there's a " before /O2 but no closing ". This will likely cause Bazel to parse the remainder of the file as part of this flag value, breaking everything after this line.
The stray quote should either be removed (to match the style used by the existing v8-codegen-opt-windows entries on lines 99-105) or a closing quote added at the end.
| build:windows --per_file_copt=.*capnp/rpc\.c++@"/O2,/Gy,/Gw,-fstrict-aliasing,/clang:-O3 | |
| build:windows --per_file_copt=.*capnp/rpc\.c++@/O2,/Gy,/Gw,-fstrict-aliasing,/clang:-O3 |
.bazelrc
Outdated
| # This file breaks our CI windows release builds when compiled using O2/O3 | ||
| # Ref: https://github.com/llvm/llvm-project/issues/136481 | ||
| build:release_windows --per_file_copt=.*capnp/rpc\.c++@/clang:-O1 | ||
| build:windows --@capnp-cpp//src/kj:debug_memory=False |
There was a problem hiding this comment.
Intentional? Moving debug_memory=False and the per-file optimizations from config:release_windows to config:windows means they now apply to all Windows build modes (fastbuild, dbg, etc.), not just release builds. In particular:
debug_memory=Falsedisables KJ debug-memory checks in all Windows builds, which line 200 explicitly enables for all platforms.- The per-file
/O2+/clang:-O3opts on lines 435-437 compilerpc.c++,server.c++, andcontainer-client.c++at high optimization even in debug builds, which can make debugging those files difficult.
If this is intentional for reproducing the crash, ignore this — just flagging it so it doesn't accidentally land as-is.
|
I'm Bonk, and I've done a quick review of your PR. This PR moves some Windows build config flags around in Two issues found, posted as review comments on PR #6416:
|
312d2f3 to
2f69192
Compare
c929b55 to
f500ffd
Compare
38ad8c2 to
67ad425
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6416 +/- ##
==========================================
- Coverage 70.79% 70.74% -0.05%
==========================================
Files 427 427
Lines 117869 117385 -484
Branches 18935 18891 -44
==========================================
- Hits 83447 83048 -399
+ Misses 23154 23090 -64
+ Partials 11268 11247 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
Comparing Footnotes
|
84da13b to
ebfc418
Compare
ebfc418 to
7b2dbe8
Compare
Not ready for review, just trying to reproduce the compiler crash/see if changing compiler options could mitigate it