Skip to content

remove slow textencoder branch #6303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
anonrig wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

remove slow textencoder branch #6303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions src/workerd/api/encoding.c++
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

#include <workerd/io/features.h>
#include <workerd/jsg/jsg.h>
#include <workerd/util/autogate.h>
#include <workerd/util/strings.h>

#include <unicode/ucnv.h>
Expand Down Expand Up @@ -523,16 +522,6 @@ jsg::Ref<TextEncoder> TextEncoder::constructor(jsg::Lock& js) {
}

jsg::JsUint8Array TextEncoder::encode(jsg::Lock& js, jsg::Optional<jsg::JsString> input) {
if (!workerd::util::Autogate::isEnabled(workerd::util::AutogateKey::ENABLE_FAST_TEXTENCODER)) {
auto str = input.orDefault(js.str());
auto view = JSG_REQUIRE_NONNULL(jsg::BufferSource::tryAlloc(js, str.utf8Length(js)), RangeError,
"Cannot allocate space for TextEncoder.encode");
[[maybe_unused]] auto result = str.writeInto(
js, view.asArrayPtr().asChars(), jsg::JsString::WriteFlags::REPLACE_INVALID_UTF8);
KJ_DASSERT(result.written == view.size());
return jsg::JsUint8Array(view.getHandle(js).As<v8::Uint8Array>());
}

jsg::JsString str = input.orDefault(js.str());

size_t utf8_length = 0;
Expand Down Expand Up @@ -710,15 +699,6 @@ size_t bestFit(const char16_t* str, size_t bufferSize) {

TextEncoder::EncodeIntoResult TextEncoder::encodeInto(
jsg::Lock& js, jsg::JsString input, jsg::JsUint8Array buffer) {
if (!workerd::util::Autogate::isEnabled(workerd::util::AutogateKey::ENABLE_FAST_TEXTENCODER)) {
auto result = input.writeInto(
js, buffer.asArrayPtr<char>(), jsg::JsString::WriteFlags::REPLACE_INVALID_UTF8);
return TextEncoder::EncodeIntoResult{
.read = static_cast<int>(result.read),
.written = static_cast<int>(result.written),
};
}

auto outputBuf = buffer.asArrayPtr<char>();
size_t bufferSize = outputBuf.size();

Expand Down
Loading