Example of using a custom generic structure to wrap extension fields #2355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPardue
commented
Feb 13, 2026
| self.lost_packets = latest.lost_packets; | ||
| emit_event = true; | ||
|
|
||
| ex_data.insert( |
Contributor
Author
There was a problem hiding this comment.
You could potentially further change ex_data to be more than a type def, and have a method that takes a CustomQlogField to simplify all of the call sites that want to insert
LPardue
commented
Feb 13, 2026
| #[derive(Serialize)] | ||
| struct TotalAndDelta { | ||
| total: Option<u64>, | ||
| delta: Option<u64>, |
Contributor
Author
There was a problem hiding this comment.
These could be values rather than options, just using it to demonstrate the power of relying on the Serialize properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic type should probably be defined outside of the recovery module, but this was just an example to help further the discussions