tests: reduce testing for aliased CC algo names #2330
+176
−207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The algorithm names "bbr2" and "bbr2_gcongestion" alias to the same value CongestionControlAlgorithm::Bbr2Gcongestion. This change removes a redundant algorithm name from paramaterized tests.
LPardue
force-pushed
the
lucas/remove-redundant-cc-testing
branch
from
a363003 to
80336c3
Compare
Member
|
Can we remove the bbr2_gcongestion one instead? I think eventually we'll want to drop that name anyway... |
Contributor
Author
|
Either one works for me, I'll defer to @antoniovicente though |
antoniovicente
approved these changes
Jan 28, 2026
Contributor
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Thanks for the cleanup.
Eventually I'ld like to change the name of the primary BBR algoritm to something along the lines of "bbr_ietf" or simply "bbr", but doing this cleanup to reduce redundant testing and less code bulk is a good first step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The algorithm names "bbr2" and "bbr2_gcongestion" alias to the same value
CongestionControlAlgorithm::Bbr2Gcongestion.
This change removes a redundant algorithm name from paramaterized tests.