FFI: Update CC algorithms to be up to date with bda63e0 #2322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPardue
approved these changes
Jan 26, 2026
antoniovicente
approved these changes
Jan 26, 2026
| QUICHE_CC_RENO = 0, | ||
| QUICHE_CC_CUBIC = 1, | ||
| QUICHE_CC_BBR = 2, | ||
| QUICHE_CC_BBR2 = 3, |
Contributor
There was a problem hiding this comment.
It would be a good idea to prefer quiche_config_set_cc_algorithm_name over this enum.
Lucas: thoughts about removing this enum and quiche_config_set_cc_algorithm?
Author
There was a problem hiding this comment.
I'm not a big fan of quiche_config_set_cc_algorithm_name because it changes its meaning. For example, "bbr" used to be "bbr v1" but is now "bbr2_gcongestion". bbr2, bbr & bbr2_gcongestion yield the same result, + it doesn't provide compile-time errors in FFI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.