fixed unused() method to properly check sent packets #2310
+17
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old Path::unused() method only looked at whether the path was inactive and missing an active destination connection ID. It didn’t actually check if there were packets still in flight or sitting in the sent queue. That could let a path get marked as unused even though it still had packets hanging around.
This update adds two more checks:
Now, both LegacyRecovery and GRecovery implement sent_packets_empty(), so they accurately report when their sent packet queues are empyt