generate packet numbers from a single sequence #1782
Merged
+15
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPardue
previously approved these changes
May 8, 2024
Instead of keeping separate sequences for each packet number space, use the same sequence. This is needed to make it easier to support FIPS. This is because FIPS mandates that the crypto module (e.g. BoringCrypto) has to validate that the AEAD counter (which in QUIC corresponds to the packet number) is stricly monotonically increasing (so that counters are not reused). Because BoringCrypto saves the counter inside its own AEAD context, and because new paths currently require starting from packet number 0 again, the FIPS requirement would require us to maintain separate AEAD contexts for each path, which we currently don't do (and would probably be messy to implement). This reverts commit 40e2433.
LPardue
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of keeping separate sequences for each packet number space, use the same sequence.
This is needed to make it easier to support FIPS. This is because FIPS mandates that the crypto module (e.g. BoringCrypto) has to validate that the AEAD counter (which in QUIC corresponds to the packet number) is stricly monotonically increasing (so that counters are not reused).
Because BoringCrypto saves the counter inside its own AEAD context, and because new paths currently require starting from packet number 0 again, the FIPS requirement would require us to maintain separate AEAD contexts for each path, which we currently don't do (and would probably be messy to implement).
This reverts commit 40e2433.