feat: add SNI field to SslDigest for HTTP filter context access#857
Open
nanookclaw wants to merge 2 commits intocloudflare:mainfrom
Open
feat: add SNI field to SslDigest for HTTP filter context access#857nanookclaw wants to merge 2 commits intocloudflare:mainfrom
nanookclaw wants to merge 2 commits intocloudflare:mainfrom
Conversation
Fixes cloudflare#547 Add sni: Option<String> to SslDigest struct so that the SNI can be retrieved from req_filter() callbacks via session.digest().ssl_digest.sni. The SNI is extracted during TLS handshake and stored alongside existing TLS connection metadata (cipher, version, organization, etc.) in the SslDigest struct. Supported across all TLS backends: - BoringSSL/OpenSSL: via ssl.servername(NameType::HOST_NAME) - Rustls: via session.server_name() - s2n: via conn.server_name() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #547
Adds an
sni: Option<String>field toSslDigestso that the Server Name Indication can be retrieved fromreq_filter()callbacks viasession.digest().ssl_digest.sni.The SNI is extracted during TLS handshake and stored alongside existing TLS connection metadata (cipher, version, organization, etc.) in the
SslDigeststruct.Changes
digest.rs: Addsni: Option<String>field toSslDigeststruct and updatenew()constructorssl.servername(ssl::NameType::HOST_NAME).map(ToOwned::to_owned)infrom_ssl()server.server_name().map(ToOwned::to_owned)fromServerConnection(returnsNonefor client connections)conn.server_name().map(ToOwned::to_owned)from the s2nConnectionUsage
After this change, users can access the SNI in their HTTP filter callbacks:
This directly addresses the use case described in #547 where the SNI is needed alongside the HTTP HOST header in
req_filter()but is currently inaccessible.Testing
sniisOption<String>so existing code is unaffected