fix: replace non-semantic border-secondary token and add missing hover styles in button variants#196
Open
matingathani wants to merge 1 commit intocloudflare:mainfrom
Open
Conversation
… variants Replace `border-secondary` (non-semantic) with `ring-kumo-ring` and add missing hover background (`hover:bg-kumo-tint`) to secondary, secondary-destructive, and outline button variants. Fixes cloudflare#35 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates Kumo’s Button variant styling to use semantic design tokens and provide consistent hover feedback across secondary-style variants, aligning with documented token usage and fixing issue #35.
Changes:
- Replaced
not-disabled:hover:border-secondary!with semanticnot-disabled:hover:ring-kumo-ringinsecondaryandsecondary-destructive. - Added
not-disabled:hover:bg-kumo-tinthover background tosecondary,secondary-destructive, andoutline. - Added
not-disabled:hover:ring-kumo-ringtooutlinefor consistent hover ring highlighting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
not-disabled:hover:border-secondary!withnot-disabled:hover:ring-kumo-ringinsecondaryandsecondary-destructivevariants —border-secondaryis not a Kumo semantic token;ring-kumo-ringis the correct semantic equivalent used elsewhere (e.g. checkbox hover)not-disabled:hover:bg-kumo-tinttosecondary,secondary-destructive, andoutlinevariants to provide visible hover feedback consistent with other interactive elementsnot-disabled:hover:ring-kumo-ringtooutlinevariant for ring highlight on hoverTest plan
secondarybutton — should show tint background and ring highlightsecondary-destructivebutton — same hover feedback, danger text color preservedoutlinebutton — should show tint background and ring highlightnot-disabled:)border-secondaryreferences remain in button componentFixes #35