feat(button): add smooth hover highlighting across all button-like components#188
Open
awhobbs87 wants to merge 5 commits intocloudflare:mainfrom
Open
feat(button): add smooth hover highlighting across all button-like components#188awhobbs87 wants to merge 5 commits intocloudflare:mainfrom
awhobbs87 wants to merge 5 commits intocloudflare:mainfrom
Conversation
commit: |
Contributor
Docs PreviewCommit: |
Contributor
…mponents - Add transition-colors duration-150 to buttonVariants() base classes - Fix outline variant missing hover state (add hover:bg-kumo-tint) - Improve secondary/secondary-destructive hover visibility (bg-kumo-control → bg-kumo-tint) - Add hover to MenuBar, Collapsible trigger, DateRange reset, Table.ResizeHandle - Normalize Toast.Close hover to match VARIANTS definition (semantic tokens) - Replace SensitiveInput copy button hover:brightness-120 with hover:bg-kumo-brand-hover - Update auto-generated component registry to reflect class changes
b7b286e to
bdc2312
Compare
Contributor
|
thanks for this! looks great overall – just one minor change: collapsible.tsx (line 16) and date-range-picker.tsx (line 655) |
Collaborator
|
@awhobbs87 this too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








































































Summary
transition-colors duration-150tobuttonVariants()base classes so all 6 Button variants animate smoothly on hover — this single change flows to ~15 downstream components (Select, InputGroup, Pagination, LinkButton, etc.)outlinevariant having zero hover state by addinghover:bg-kumo-tintsecondaryandsecondary-destructivehover visibility — previously hovered tobg-kumo-controlwhich was the same as the resting background, now usesbg-kumo-tintAdditional components fixed
MenuOption)hover:bg-kumo-overlayon inactive buttonshover:text-kumo-brandwith transitionhover:text-kumo-brandwith transitionhover:bg-kumo-tintwith transitionhover:bg-kumo-contrast/10hover:bg-kumo-fill-hover hover:text-kumo-strong(matches KUMO_TOAST_VARIANTS)hover:brightness-120hover:bg-kumo-brand-hoverDesign decisions
duration-150(150ms) for a snappy but smooth feeldark:variantsai/component-registry.{json,md}updated to reflect the new class stringsFiles changed (7 source + 2 auto-generated + 1 changeset)
packages/kumo/src/components/button/button.tsxpackages/kumo/src/components/menubar/menubar.tsxpackages/kumo/src/components/collapsible/collapsible.tsxpackages/kumo/src/components/date-range-picker/date-range-picker.tsxpackages/kumo/src/components/table/table.tsxpackages/kumo/src/components/toast/toast.tsxpackages/kumo/src/components/sensitive-input/sensitive-input.tsxpackages/kumo/ai/component-registry.json(auto-generated)packages/kumo/ai/component-registry.md(auto-generated).changeset/slick-button-hover.md