[kumo] Add background tint to secondary button hover state#185
Open
tccloudflare wants to merge 2 commits intocloudflare:mainfrom
Open
[kumo] Add background tint to secondary button hover state#185tccloudflare wants to merge 2 commits intocloudflare:mainfrom
tccloudflare wants to merge 2 commits intocloudflare:mainfrom
Conversation
mattrothenberg
requested changes
Mar 5, 2026
Collaborator
mattrothenberg
left a comment
mattrothenberg
left a comment
There was a problem hiding this comment.
Thank you! Can we add classes for the focus state, too?
commit: |
Contributor
Docs PreviewCommit: |
Contributor
Visual Regression Report1 screenshot(s) with visual changes: Button / Loading State7 px (0%) changed
5 screenshot(s) unchanged
Generated by Kumo Visual Regression |
tccloudflare
force-pushed
the
feat/secondary-button-hover
branch
from
74e9d0a to
9217d6b
Compare
Author
Yes, just added the update. |
Brayden
reviewed
Mar 17, 2026
Collaborator
Brayden
left a comment
Brayden
left a comment
There was a problem hiding this comment.
Looking between the proposed changes here in the Docs Preview link versus what is live in kumo-ui.com but can't spot the difference on hover state.
I think the only change here (now) is the focus state on a not-disabled secondary button. Can we change the patch notes to reflect that by chance?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the color Kumo-tint to the secondary button hover state.