Open
Conversation
This was referenced Nov 28, 2019
Closed
Closed
|
I tested it and it works. 👍 There does seem to be a significant size increase. From 196MB to 3.09GB. For automatic deployments that regularly rebuild because you want the latest nmap-scripts, I think this might start to add up. On one hand I really want this in the repo and on the other hand I feel like it might not be suitable as a default. Here's an idea. What about putting this in a separate container specifically building the reports. Create a separate Dockerfile that can be build and run from the same Makefile. The advantages would be that:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a report pdf file gets created and uploaded alongside the tex file
Fixes #8