Skip to content

Strip the opener from every link a Gadget UI opens #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RenKoya1 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

Strip the opener from every link a Gadget UI opens #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/workshop-frontend/src/GadgetUI.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,19 @@ window.addEventListener('keydown', (event) => {
}
}, true);

// Strip the opener from every link the user clicks. This deliberately does not try to work out
// which links open a new context: a link with no target attribute of its own still opens one when
// the document carries a <base target="_blank">, which the CSP's base-uri does not restrict, and an
// SVG anchor's .target is an SVGAnimatedString rather than a string. Since the frame's popups
// escape the sandbox, missing one matters; adding rel=noopener to a same-context navigation
// does not, because it is inert there.
window.addEventListener('click', (event) => {
if (!(event.target instanceof Element)) {
return;
}

const anchor = event.target.closest('a[href][target]');
if (!anchor || anchor.target.toLowerCase() !== '_blank') {
const anchor = event.target.closest('a[href]');
if (!anchor) {
return;
}

Expand Down
Loading