fix: invoke pnpm via npm_execpath on Windows (fixes #19) - #107
Open
Sainigurnoor511 wants to merge 1 commit into
Open
fix: invoke pnpm via npm_execpath on Windows (fixes #19)#107Sainigurnoor511 wants to merge 1 commit into
Sainigurnoor511 wants to merge 1 commit into
Conversation
On Windows, execFileSync(pnpm, ...) fails because pnpm is a .cmd shim (ENOENT/EINVAL). Use pnpm's JS entry from npm_execpath when launched via pnpm run so argv survives intact, including paths with spaces. Fixes cloudflare#19 Co-authored-by: Cursor <cursoragent@cursor.com>
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pm_execpath\ points at pnpm's .cjs/.mjs\ entry (as under \pnpm run), run
ode ...\ so argv boundaries survive intact.
pm-cli.js\ via the path guard so
pm run\ does not silently use the wrong package manager.
esult.error\ is set (misleading wrangler error today).
Fixes #19
Approach
Follows the approach discussed in #19 / @snowyukitty's analysis: no shell, no .cmd\ shim, arguments stay intact (including checkout paths with spaces).
Test plan
CLA
I have read the CLA Document and I hereby sign the CLA