Codex/fix gatekeeper app accent theme - #105
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Would it be possible to provide some before and after screenshots of your change? |
ndisidore
left a comment
There was a problem hiding this comment.
This is looking good to me! I looked briefly into this and came to a similar changeset.
Agree before/after pictures would be nice to have
|
Sure thing! cc @Maximo-Guk and @ndisidore Before: New collection and create buttons button are default Cloudflare Orange despite the app theme being changed. However the New Workspace button correctly adopts the new theme After: The app passes through the user-specified app theme to the built-in gatekeepers' iframes |
|
@ask-bonk review this |
|
Checking this out and testing locally I found a few issues e.g. ServerConfigContext, which is likely only populated at boot, while the admin color picker updates the host DOM directly Also I think it probably makes sense to roll into the single theme RPC: |





After setting up my Cloudflare OS instance with a custom accent color, I noticed that the primary call to action buttons in the Schedule and Context tabs were using the default orange. This pull request propagates the accent colors into the built-in gatekeeper iframe.
The change is narrowly focused on the accent color and follows the same pattern as the theme subscription.