Skip to content

Codex/fix gatekeeper app accent theme - #105

Closed
deloreyj wants to merge 2 commits into
cloudflare:mainfrom
deloreyj:codex/fix-gatekeeper-app-accent-theme
Closed

Codex/fix gatekeeper app accent theme#105
deloreyj wants to merge 2 commits into
cloudflare:mainfrom
deloreyj:codex/fix-gatekeeper-app-accent-theme

Conversation

@deloreyj

@deloreyj deloreyj commented Aug 9, 2026

Copy link
Copy Markdown

After setting up my Cloudflare OS instance with a custom accent color, I noticed that the primary call to action buttons in the Schedule and Context tabs were using the default orange. This pull request propagates the accent colors into the built-in gatekeeper iframe.

The change is narrowly focused on the accent color and follows the same pattern as the theme subscription.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@deloreyj

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Aug 10, 2026
@Maximo-Guk

Copy link
Copy Markdown
Member

Would it be possible to provide some before and after screenshots of your change?

@ndisidore ndisidore left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me! I looked briefly into this and came to a similar changeset.
Agree before/after pictures would be nice to have

@deloreyj

Copy link
Copy Markdown
Author

Sure thing! cc @Maximo-Guk and @ndisidore

Before: New collection and create buttons button are default Cloudflare Orange despite the app theme being changed. However the New Workspace button correctly adopts the new theme
image
image
image

After: The app passes through the user-specified app theme to the built-in gatekeepers' iframes
image
image

@ndisidore

Copy link
Copy Markdown
Contributor

@ask-bonk review this

@ndisidore

Copy link
Copy Markdown
Contributor

Checking this out and testing locally I found a few issues e.g. ServerConfigContext, which is likely only populated at boot, while the admin color picker updates the host DOM directly

Also I think it probably makes sense to roll into the single theme RPC:
I took a stab at what I think may be a better approach here: #155 utilizing useSyncExternalStore

@ndisidore ndisidore closed this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants