FLPROD-1370: Add client for CloudConnectorAPI #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
WowVeryLogin
force-pushed
the
denis/FLPROD-1370
branch
from
edeaee4
to
5a5122b
Compare
|
|
||
| type CloudConnectorRule struct { | ||
| ID string `json:"id"` | ||
| Enabled bool `json:"enabled"` |
There was a problem hiding this comment.
Suggested change
| Enabled bool `json:"enabled"` | |
| Enabled *bool `json:"enabled"` |
https://github.com/cloudflare/cloudflare-go/blob/master/docs/conventions.md#booleans
|
can you link to the external API schemas for this one? i'm not seeing it in api-schemas which suggests we don't have this documented yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FL Team: new product CloudConnector designed to create rules similar to ERE rules for connecting cloud providers for a zone.
Supports: GET and PUT methods.