Skip to content

ERE-3686: clarify Access phase ordering - #32686

Open
neetsots wants to merge 1 commit into
productionfrom
emitrani/ERE-3686
Open

ERE-3686: clarify Access phase ordering#32686
neetsots wants to merge 1 commit into
productionfrom
emitrani/ERE-3686

Conversation

@neetsots

Copy link
Copy Markdown
Collaborator

Summary

Clarifies the Ruleset Engine phase list for Cloudflare Access by distinguishing Access application checking from later Access enforcement and handling phases.

Documentation checklist

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ 1 warning found in commit 1ac4376.

👉 Fix in your agent 👈
Fix the following review findings in PR #32686 (https://github.com/cloudflare/cloudflare-docs/pull/32686).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Style Guide Review

### Warnings (1)

#### SG-4450f9f300e1 · No directional words (`above`, `below`) in prose
- **File:** `src/content/docs/ruleset-engine/reference/phases-list.mdx` line 60
- **Issue:** Line adds: "For Cloudflare Access, the row above refers to Access application checking."
- **Fix:** Replace the directional reference with a direct reference by name, e.g. "For Cloudflare Access, the `Cloudflare Access` row refers to Access application checking."

Code Review

This code review is in beta and may not always be helpful — use your judgment.

No code review issues found.

Conventions

No convention issues found.

Style Guide Review

Warnings (1)
File Issue
ruleset-engine/reference/phases-list.mdx line 60 No directional words (above, below) in prose — Line adds: "For Cloudflare Access, the row above refers to Access application checking." Fix: Replace the directional reference with a direct reference by name, e.g. "For Cloudflare Access, the Cloudflare Access row refers to Access application checking."
Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/ruleset-engine/ @cloudflare/appsec-reviewers, @elithrar, @maurizioabba, @cloudflare/product-owners

@github-actions

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants