Update nodejs_compat status - #32549
Conversation
Review
👉 Fix in your agent 👈Fix the following review findings in PR #32549 (https://github.com/cloudflare/cloudflare-docs/pull/32549).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Style Guide Review
### Warnings (1)
#### SG-cec77a382619 · Use turn on / turn off instead of enable/disable (for toggles)
- **File:** `src/content/partials/workers/nodejs_compat.mdx` line 7
- **Issue:** Line uses `enable` for compatibility flags: "Workers and Pages projects enable both `nodejs_compat` and `nodejs_compat_v2` by default."
- **Fix:** Change `enable` to `turn on`: "Workers and Pages projects turn on both `nodejs_compat` and `nodejs_compat_v2` by default."
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsNo convention issues found. Style Guide ReviewWarnings (1)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
415b756 to
c3dd8c0
Compare
|
/bonk please review and update based on feedback |
|
I've reviewed all changed files and the bot feedback. Here's my assessment: Bot Feedback — All Agreed
Additional Finding (Bot Missed)File: Other ObservationsThe content changes themselves are accurate and well-structured:
Note: This run is in |
c3dd8c0 to
40f30eb
Compare
|
/bonk re-review. review comments addressed in squashed commit |
This comment was marked as resolved.
This comment was marked as resolved.
|
Have disabled auto merge as we want to wait for this to land in workers-sdk for local dev first. |
|
Updated this PR to align the documentation with workers-sdk #15123:
Validation completed successfully with formatting, |
a2e2a77 to
ccbef83
Compare
|
Follow-up documentation update for workers-sdk #15148, superseding the earlier redundant-flag recovery guidance:
Formatting, |
Summary
Add a changelog entry and update the Workers docs to reflect that
nodejs_compatandnodejs_compat_v2default on for compatibility dates of2026-08-04or later. Document the valid opt-in dates, complete opt-out flags, and that Workers developer tools ignore redundant positive flags so existing projects can update without removing them.Related implementation: cloudflare/workers-sdk#15123 and cloudflare/workers-sdk#15148
Documentation checklist