Fix legacy type into zod fallback

cloudflare · Jun 9, 2024 · a8cc538 · a8cc538
1 parent 7d8f4ef
commit a8cc538
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 20 deletions.
diff --git a/rollup.config.mjs b/rollup.config.mjs
@@ -26,5 +26,5 @@ export default defineConfig({
       ],
     }),
   ],
-  external: ['itty-router', 'zod', '@asteasolutions/zod-to-openapi', 'js-yaml'],
+  external: ['itty-router', 'zod', '@asteasolutions/zod-to-openapi', 'js-yaml', 'openapi3-ts'],
 })
diff --git a/src/openapi.ts b/src/openapi.ts
@@ -8,7 +8,6 @@ import {
 } from '@asteasolutions/zod-to-openapi'
 import { OpenAPIRegistryMerger } from './zod/registry'
 import { z } from 'zod'
-import { OpenAPIObject } from 'openapi3-ts/oas31'
 import yaml from 'js-yaml'
 
 export type OpenAPIRouterType<M> = {
@@ -95,7 +94,7 @@ export class OpenAPIHandler {
     }
   }
 
-  getGeneratedSchema(): OpenAPIObject {
+  getGeneratedSchema() {
     let openapiGenerator: any = OpenApiGeneratorV31
     if (this.options?.openapiVersion === '3')
       openapiGenerator = OpenApiGeneratorV3

diff --git a/src/parameters.ts b/src/parameters.ts
@@ -6,7 +6,9 @@ import {
 import { z } from 'zod'
 import { isSpecificZodType, legacyTypeIntoZod } from './zod/utils'
 import { RouteParameter } from '@asteasolutions/zod-to-openapi/dist/openapi-registry'
+import { extendZodWithOpenApi } from '@asteasolutions/zod-to-openapi'
 
+extendZodWithOpenApi(z)
 export function convertParams<M = z.ZodType>(field: any, params: any): M {
   params = params || {}
   if (params.required === false)
@@ -44,19 +46,13 @@ export function Obj(fields: object, params?: ParameterType): z.ZodObject<any> {
 }
 
 export function Num(params?: ParameterType): z.ZodNumber {
-  return convertParams<z.ZodNumber>(
-    z.number().or(z.string()).pipe(z.number()),
-    params
-  ).openapi({
+  return convertParams<z.ZodNumber>(z.number(), params).openapi({
     type: 'number',
   })
 }
 
 export function Int(params?: ParameterType): z.ZodNumber {
-  return convertParams<z.ZodNumber>(
-    z.number().int().or(z.string()).pipe(z.number()),
-    params
-  ).openapi({
+  return convertParams<z.ZodNumber>(z.number().int(), params).openapi({
     type: 'integer',
   })
 }
@@ -223,11 +219,20 @@ export function coerceInputs(
         if (_val === 'true' || _val === 'false') {
           params[key] = _val === 'true'
         }
-      } else if (isSpecificZodType(innerType, 'ZodNumber')) {
+      } else if (
+        isSpecificZodType(innerType, 'ZodNumber') ||
+        innerType instanceof z.ZodNumber
+      ) {
         params[key] = parseFloat(params[key])
-      } else if (isSpecificZodType(innerType, 'ZodBigInt')) {
+      } else if (
+        isSpecificZodType(innerType, 'ZodBigInt') ||
+        innerType instanceof z.ZodBigInt
+      ) {
         params[key] = parseInt(params[key])
-      } else if (isSpecificZodType(innerType, 'ZodDate')) {
+      } else if (
+        isSpecificZodType(innerType, 'ZodDate') ||
+        innerType instanceof z.ZodDate
+      ) {
         params[key] = new Date(params[key])
       }
     }

diff --git a/src/zod/registry.ts b/src/zod/registry.ts
@@ -6,6 +6,8 @@ export class OpenAPIRegistryMerger extends OpenAPIRegistry {
   public _definitions: OpenAPIDefinitions[] = []
 
   merge(registry: OpenAPIRegistryMerger): void {
+    if (!registry || !registry._definitions) return
+
     for (const definition of registry._definitions) {
       this._definitions.push({ ...definition })
     }

diff --git a/src/zod/utils.ts b/src/zod/utils.ts
@@ -41,11 +41,6 @@ export function legacyTypeIntoZod(type: any, params?: any): z.ZodType {
     return type
   }
 
-  // Legacy support
-  if (type.generator === true) {
-    return new type(params) as z.ZodType
-  }
-
   if (type === String) {
     return Str(params)
   }
@@ -86,5 +81,6 @@ export function legacyTypeIntoZod(type: any, params?: any): z.ZodType {
     return Obj(type, params)
   }
 
-  throw new Error(`${type} not implemented`)
+  // Legacy support
+  return type(params)
 }