fix(think): preserve regeneration branch context - #2038
Open
ben-reitz wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 24f92d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
create-think
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
ben-reitz
marked this pull request as ready for review
August 5, 2026 08:44
ben-reitz
marked this pull request as draft
August 5, 2026 13:03
ben-reitz
marked this pull request as ready for review
August 6, 2026 11:04
ben-reitz
force-pushed
the
fix/think-regeneration-context
branch
from
August 6, 2026 14:08
6133537 to
f77f98a
Compare
ben-reitz
force-pushed
the
fix/think-regeneration-context
branch
from
August 7, 2026 07:24
f77f98a to
24f92d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Regeneration means “answer this user message again” while keeping the previous answer available. Think already stored the new answer as a sibling, but it generated that answer from the wrong history.
The result looked like a new branch in storage, but the model had been asked to continue the old answer instead of producing an independent alternative.
Fix
Think now uses one server-validated branch point for both model input and output storage. For regeneration, model history ends at the selected user message, and the generated answer is stored beneath that same message.
The selected branch is also preserved through hooks, retries, context compaction, Durable Object eviction recovery, and partial-response reconstruction. Re-delivered recovery work is idempotent, so it cannot create duplicate alternatives.
Summary
Fixes #2028
Testing
pnpm run checkpnpm --dir packages/agents run test:chat— 514 passedpnpm --dir packages/think run test:workers— 923 passed