Fix dropped async callable replies on facets - #2027
Open
cjol wants to merge 6 commits into
Open
Conversation
Co-authored-by: Dustin Graham <dustin.graham@hhandr.com>
🦋 Changeset detectedLatest commit: dea62cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
create-think
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR routes callable replies on facet WebSockets through the bridge that delivered the originating RPC frame. Fixes #1991.
Why
Connection, but each forwarded frame arrives with a temporarySubAgentConnectionBridge.connection.send()calls and broadcasts represent durable connection operations and must not inherit a short-lived frame transport.onMessagewrappers installed byAIChatAgent, Think, or application middleware.Architectural Changes
Before:
After:
Code Changes
onMessagewrappers without changing general virtual connection behavior.StreamingResponseAPI while tracking pending bridge deliveries and flushing them before the callable invocation returns.agentspatch changeset.