Skip to content

Conversation

@PlugaruT
Copy link

Changes

  • Support Spec version v0.3

One line description for the changelog

  • Tests pass
  • Appropriate changes to README are included in PR

@PlugaruT
Copy link
Author

cc @xSAVIKx

Copy link
Member

@xSAVIKx xSAVIKx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PlugaruT overall LGTM 👍

Comment on lines +17 to +19
# CloudEvents specification version constants
SPECVERSION_V1_0 = "1.0"
SPECVERSION_V0_3 = "0.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move these constants to spec.py or spec_version.py.

I'd also recommend giving a bit better type hints support by using this as:

SpecVersion = Literal["1.0", "0.3"]

SPEC_VERSION_V1_0: Final[SpecVersion] = "1.0"
SPEC_VERSION_V0_3: Final[SpecVersion] = "0.3"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants