Skip to content

Add support for request timeout in HTTP transport #564

Open

Description

@gnarea

I'd be happy to propose a PR, but I'd recommend rewriting the transport with fetch instead of extending the current approach:

const req = base.request(url, opts, (res: Socket) => {

... As I'd have to use setTimeout(), which would make the code more complicated.

The drawback of fetch() is that it'd require Node.js 18+. Which shouldn't be too bad as Node.js 16 is reaching EOL in a few weeks.

Activity

  1. lholmquist commented on Jul 31, 2023

    @lholmquist
    Contributor

    @gnarea feel free to submit a PR 👍

    looks like the exact date it the 11th of September for node 16 EOL, so probably wouldn't merge until then

  2. github-actions commented on Aug 31, 2023

    @github-actions
    Contributor

    This issue is stale because it has been open 30 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions